Skip navigation.
KDE Developer's Journals
Home » blogs » carewolf's blog

Yet another GMail fix

carewolf's picture
Submitted by carewolf on Fri, 05/18/2007 - 09:12.

As some might have noticed GMail was updated this morning. As usual this broke the standard view Konqueror, but only if you use the recommended method of spoofing as Firefox.

Fortunately I traced it down and fixed it in no time at all Laughing out loud

Here is the patch for your convenience (apply in kdelibs/khtml):

--- /home/carewolf/html_elementimpl.cpp 2007-05-18 10:48:33.000000000 +0200
+++ html/html_elementimpl.cpp 2007-05-18 10:50:36.000000000 +0200
@@ -562,6 +562,13 @@

void HTMLElementImpl::setInnerHTML( const DOMString &html, int &exceptioncode )
{
+ // Works line innerText in Gecko
+ // ### test if needed for ID_SCRIPT as well.
+ if ( id() == ID_STYLE ) {
+ setInnerText(html, exceptioncode);
+ return;
+ }
+
DocumentFragment fragment = createContextualFragment( html );
if ( fragment.isNull() ) {
exceptioncode = DOMException::NO_MODIFICATION_ALLOWED_ERR;

» carewolf's blog | login or register to post comments | 966 reads

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
carlo's picture

Hi Allen, care to explain

Submitted by carlo on Thu, 05/24/2007 - 17:00.

Hi Allen, care to explain why you're posting the fix, but not committing it? Any problems with it!?

» login or register to post comments
vdboor's picture

Curious...

Submitted by vdboor on Fri, 05/18/2007 - 12:10.

Cool to see such patch.

Have two questions though:
- what JavaScript line causes this problem?
- And are these kind of necessary hacks documented somewhere? For example, the fact window.frames[ id ] returns any DOM element in MSIE, or location = location.href also works. Sticking out tongue

» login or register to post comments
carewolf's picture

Answer

Submitted by carewolf on Fri, 05/18/2007 - 14:36.

These lines are responsible:

if(BU)
{c.cssText=b}
else if(B9)
{c.innerText=b}
else
{c.innerHTML=b}

Where BU is set on MSIE UserAgent, and B9 set on Safari UserAgent.

So the short answers is that stuff like this happens because GMail is horrible piece of crappy enginering.

The correct way to do this would have been to test for the properties cssText or innerText on StyleElements, and only use the innerHTML gecko-hack if anything sane fails. Unfortunately the JS-idiots at Google are incapable of using anything other than UserAgent switches.

» login or register to post comments
superstoned's picture

3.5.7

Submitted by superstoned on Fri, 05/18/2007 - 10:41.

is this going to make it in KDE 3.5.7? I know it's tagged, but this sounds like it's worth it...

» login or register to post comments

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.